Merged
Conversation
- Reorder Detach() defs - Assign GunController in Attach() - Actually call Detach()
Animator was triggered from both the body and the animator script. Removed it from the animator as removing it from the body made me unable to shoot, likely because the animator has to call methods on the body class. Did not fix the eternally frustrating revolver bug, but it seems to take longer to trigger now???
Fueredoriku
approved these changes
Sep 1, 2025
Contributor
Fueredoriku
left a comment
Fueredoriku
left a comment
There was a problem hiding this comment.
looks good, couldnt find any big issues from these changes after testing
github-project-automation
Bot
moved this from Review
to Done 🎉
in Prosjekt-Spill-H22 board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took all the not-so-risky fixes from #975 and put them into this PR so we at least have some of these improvements 😔